Skip to content

chore(runtime): consume adapter-core writeback normalizer#245

Merged
khaliqgant merged 1 commit into
mainfrom
chore/adapter-core-0.3.60
Jun 18, 2026
Merged

chore(runtime): consume adapter-core writeback normalizer#245
khaliqgant merged 1 commit into
mainfrom
chore/adapter-core-0.3.60

Conversation

@khaliqgant

@khaliqgant khaliqgant commented Jun 18, 2026

Copy link
Copy Markdown
Member

Summary

  • bump @relayfile/adapter-core to 0.3.60 in runtime/persona-kit
  • replace the temporary runtime writeback fallback shim with the published normalizeWritebackStatus and WritebackError exports
  • keep the writeJsonFile wrapper behavior from fix(runtime): surface writeback no-receipt failures #244, including explicit writebackTimeoutMs=0 fire-and-forget pass-through

Tests

  • pnpm --filter @agentworkforce/runtime test
  • pnpm --filter @agentworkforce/mcp-workforce test

Review in cubic

@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@khaliqgant, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 28 minutes and 22 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bc023eb1-f402-4759-a65c-015739b85b44

📥 Commits

Reviewing files that changed from the base of the PR and between c4fe7f1 and 898e35f.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • packages/persona-kit/package.json
  • packages/runtime/package.json
  • packages/runtime/src/clients/index.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/adapter-core-0.3.60

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@khaliqgant khaliqgant merged commit c9a857b into main Jun 18, 2026
3 checks passed
@khaliqgant khaliqgant deleted the chore/adapter-core-0.3.60 branch June 18, 2026 19:44

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 898e35f39a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +3 to +4
normalizeWritebackStatus,
WritebackError,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore the writeback shim until core exports exist

In the bumped @relayfile/adapter-core 0.3.60 source for vfs-client, these new named exports are not present, so this import (and the matching re-exports below) makes the runtime package fail to compile with missing-export errors before any tests can run. This affects every consumer installing this commit's lockfile/package range, so the wrapper needs to keep the local shim or wait for a core version that actually publishes normalizeWritebackStatus, WritebackError, and the normalized status types.

Useful? React with 👍 / 👎.

@agent-relay-code

Copy link
Copy Markdown
Contributor

The adapter-core normalizeWritebackStatus is behaviorally equivalent to the removed local fallback for the paths the runtime relies on:

  • No receipt → state: 'no_receipt' (matches old fallback). The runtime's fire-and-forget guard (writebackTimeoutMs === 0 && state === 'no_receipt') still works, and the error path for other no_receipt cases still throws. Confirmed by the passing tests.
  • Receipt present → state: 'succeeded' with id derived identically (receipt.id ?? receipt.created). Matches old fallback.

The behavior is preserved. No fail-closed→fail-open regression. The runtime's writeJsonFile logic (the safety-critical guard) is unchanged by this PR — only the source of normalizeWritebackStatus/WritebackError moved from a local fallback to the upstream package.

This PR is a clean dependency-consolidation change with full CI green. I found no issues requiring edits. There are no bot or reviewer comments to address. No mechanical fixes needed.


Review Summary

PR #245 (cloud #2297): chore(runtime): consume adapter-core writeback normalizer

The PR bumps @relayfile/adapter-core from ^0.3.59 to ^0.3.60 in persona-kit and runtime, updates pnpm-lock.yaml accordingly, and deletes the ~100-line local fallback implementation in packages/runtime/src/clients/index.ts (the FallbackWritebackError class, the AdapterVfsClientExtensions shim, and the local NormalizedWritebackState/NormalizedWritebackStatus types + normalizeWritebackStatus). These are now imported directly from @relayfile/adapter-core/vfs-client, which provides them natively in 0.3.60.

Verification (ran the full CI sequence end-to-end):

  • pnpm install --frozen-lockfile — clean, "Lockfile is up to date" (lockfile changes are consistent)
  • pnpm -r run build — all 15 packages built, including runtime and persona-kit
  • pnpm run lint — pass
  • pnpm run typecheck — pass (confirms all 17 imported symbols, including the 4 moved ones, resolve against 0.3.60)
  • pnpm run test — all packages pass, 0 failures, including the three writeback tests in packages/runtime/src/clients/index.test.ts

Behavioral / safety checks:

  • Confirmed adapter-core 0.3.60 exports normalizeWritebackStatus, WritebackError, NormalizedWritebackState, NormalizedWritebackStatus (and the rest).
  • Confirmed adapter-core's WritebackError extends RelayfileWritebackError, so the instanceof WorkforceIntegrationError assertion in index.test.ts:53 still holds (both resolve to the same installed adapter-core class — no dual-package hazard).
  • Compared adapter-core's normalizeWritebackStatus against the removed local fallback: equivalent for the states the runtime depends on — no_receipt when receipt absent, succeeded (with id = receipt.id ?? receipt.created) when present.
  • The safety-critical guard in writeJsonFile (writebackTimeoutMs === 0 && normalized.state === 'no_receipt' → return without throwing; otherwise throw) is unchanged by this PR. No fail-closed→fail-open regression.

Files edited: none. No mechanical/lint fixes were required; the working tree is left unchanged.

Addressed comments

  • No bot or reviewer comments were present. .workforce/ contains only pr.diff, changed-files.txt, and context.json (no comments/threads), and context.json carries no review metadata. Nothing to address.

Advisory Notes

  • None. The change is self-contained and within the PR's stated purpose (consuming the adapter-core writeback normalizer).

The PR is a clean dependency consolidation, fully green across build/lint/typecheck/test with no behavioral changes. The remaining merge decision is human judgment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant